Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hooks): return the ref container with isMouseDown #1038

Merged
merged 4 commits into from
May 7, 2020

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented May 7, 2020

What:
Return the container object from useMouseAndTouchTracker.

Why:

To return the updated result properly between re-renders.

How:
Return the ref with the object that is getting updated by the mouse and touch handlers we are setting in useMouseAndTouchTracker.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

Fixes #1037.

@silviuaavram silviuaavram merged commit de3da1e into master May 7, 2020
@silviuaavram silviuaavram deleted the fix/mouse-touch-tracking-regression branch May 7, 2020 17:23
@silviuaavram
Copy link
Collaborator Author

🎉 This PR is included in version 5.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items stay open with useSelect in version 5.2.5
1 participant