-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks api #683
Comments
it makes sense and I like the idea. I just did not have time myself to explore it. |
this could be a good benchmark https://github.com/react-dropzone/react-dropzone |
I have just started looking at hooks and it is really amazing. I like the idea to rewrite it with hooks. |
This package can still be used in a function component using hooks without any changes correct? |
Hey guys, what do you think? any suggestion? I'll work in a PR |
That is great news! I only wished that this did not appear out of nowhere. But nevertheless it's a very awesome work! We should aim to collaborate for a unified solution. I am also working on https://github.com/silviuavram/downshift-hooks. I am close to release it as npm which is what I will do since I came this far. My idea was to start with a normal dropdown hook and have hooks for each: dropdown and combobox, single and multiple. Those are different patterns in ARIA and maybe it's better to have separate logic for each. What do you think? Edit: released the first hook in |
can we run both implementation on tests of this repo, so we can make sure they don't break anything |
@silviuavram great job with @sibelius good idea, we can try to apply the same test suite of this repo |
#860 code already in for |
Every render props can be replaced with hooks api
I think it makes sense to provide hooks apis for downshift, after the hooks apis landed, we can start rewriting the core of it to use hooks
what do you think?
related to this https://twitter.com/sseraphini/status/1102602849152843776
The text was updated successfully, but these errors were encountered: