Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove keyboardKey library and replace its uses #776

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

silviuaavram
Copy link
Collaborator

Added as part of 3.3.0 but will remove it to shave the bundle size a bit.

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #776 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #776   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines         705    705           
  Branches      153    153           
=====================================
  Hits          705    705
Impacted Files Coverage Δ
src/hooks/useSelect/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f72cf3...9e002dc. Read the comment docs.

@silviuaavram silviuaavram merged commit 66bc9ea into master Sep 27, 2019
@silviuaavram silviuaavram deleted the perf/remove-keyboard-key branch September 27, 2019 08:52
@silviuaavram
Copy link
Collaborator Author

🎉 This PR is included in version 3.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants