fix(@dpc-sdp/ripple-ui-core): fix divider displaying when no cobrand

dpc-sdp · Aug 23, 2023 · f23bc0b · f23bc0b
1 parent 305936c
commit f23bc0b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/examples/nuxt-app/test/fixtures/site/disable-vic-logo.json b/examples/nuxt-app/test/fixtures/site/disable-vic-logo.json
@@ -6,6 +6,11 @@
     "twitter": {},
     "og": {}
   },
+  "siteLogo": {
+    "href": "/",
+    "src": "https://placehold.co/140x40",
+    "altText": ""
+  },
   "featureFlags": {
     "disablePrimaryLogo": true
   },

diff --git a/packages/ripple-ui-core/src/components/primary-nav/components/nav-bar/RplPrimaryNavBar.vue b/packages/ripple-ui-core/src/components/primary-nav/components/nav-bar/RplPrimaryNavBar.vue
@@ -105,7 +105,10 @@ const handleToggleItem = (level: number, item) => {
       </RplLink>
 
       <!-- Logo divider -->
-      <div v-if="secondaryLogo" class="rpl-primary-nav__logo-divider"></div>
+      <div
+        v-if="secondaryLogo && !disablePrimaryLogo"
+        class="rpl-primary-nav__logo-divider"
+      ></div>
 
       <!-- Secondary logo -->
       <RplLink