Skip to content

Commit

Permalink
Add a bunch of TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffwidman committed Oct 22, 2018
1 parent d8eda04 commit 5cb41a9
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/apidoc/kafka.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ kafka.cluster module
:show-inheritance:


# TODO should this be pointing at client_async?
kafka.client module
-------------------

Expand Down
2 changes: 1 addition & 1 deletion kafka/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def emit(self, record):
from kafka.conn import BrokerConnection
from kafka.protocol import (
create_message, create_gzip_message, create_snappy_message)
from kafka.partitioner import RoundRobinPartitioner, HashedPartitioner, Murmur2Partitioner
from kafka.partitioner import RoundRobinPartitioner, HashedPartitioner, Murmur2Partitioner # TODO Murmur2Partitioner might be removable?
from kafka.structs import TopicPartition, OffsetAndMetadata
from kafka.serializer import Serializer, Deserializer

Expand Down
1 change: 1 addition & 0 deletions kafka/partitioner/hashed.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def partition(self, key, partitions=None):
return partitions[idx]


# TODO is this already done?
# Default will change to Murmur2 in 0.10 release
HashedPartitioner = LegacyPartitioner

Expand Down
1 change: 1 addition & 0 deletions kafka/producer/buffer.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ def queued(self):
with self._lock:
return len(self._waiters)

# TODO should this be removed or finished?
'''
class BufferPool(object):
"""
Expand Down
1 change: 1 addition & 0 deletions kafka/protocol/struct.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def __eq__(self, other):
return False
return True

# TODO should this be removed or finished?
"""
class MetaStruct(type):
def __new__(cls, clsname, bases, dct):
Expand Down

0 comments on commit 5cb41a9

Please sign in to comment.