Skip to content

Commit 5cb41a9

Browse files
committed
Add a bunch of TODOs
1 parent d8eda04 commit 5cb41a9

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

docs/apidoc/kafka.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ kafka.cluster module
2323
:show-inheritance:
2424

2525

26+
# TODO should this be pointing at client_async?
2627
kafka.client module
2728
-------------------
2829

kafka/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def emit(self, record):
2525
from kafka.conn import BrokerConnection
2626
from kafka.protocol import (
2727
create_message, create_gzip_message, create_snappy_message)
28-
from kafka.partitioner import RoundRobinPartitioner, HashedPartitioner, Murmur2Partitioner
28+
from kafka.partitioner import RoundRobinPartitioner, HashedPartitioner, Murmur2Partitioner # TODO Murmur2Partitioner might be removable?
2929
from kafka.structs import TopicPartition, OffsetAndMetadata
3030
from kafka.serializer import Serializer, Deserializer
3131

kafka/partitioner/hashed.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ def partition(self, key, partitions=None):
2626
return partitions[idx]
2727

2828

29+
# TODO is this already done?
2930
# Default will change to Murmur2 in 0.10 release
3031
HashedPartitioner = LegacyPartitioner
3132

kafka/producer/buffer.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ def queued(self):
238238
with self._lock:
239239
return len(self._waiters)
240240

241+
# TODO should this be removed or finished?
241242
'''
242243
class BufferPool(object):
243244
"""

kafka/protocol/struct.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def __eq__(self, other):
6565
return False
6666
return True
6767

68+
# TODO should this be removed or finished?
6869
"""
6970
class MetaStruct(type):
7071
def __new__(cls, clsname, bases, dct):

0 commit comments

Comments
 (0)