Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do not run with PhantomJS. #33

Closed
dpmcmlxxvi opened this issue Apr 22, 2018 · 2 comments
Closed

Tests do not run with PhantomJS. #33

dpmcmlxxvi opened this issue Apr 22, 2018 · 2 comments
Assignees
@dpmcmlxxvi
Labels
bug

Comments

@dpmcmlxxvi
Copy link
Owner

dpmcmlxxvi commented Apr 22, 2018 •
edited
Loading

Apparently Turf is broken in PhantomJS (Turfjs/turf#1245, Turfjs/turf#1243). This is causing the tests to quietly fail and no tests are registered. Currently shows "0 passed!' with out indicating any failures on Travis or Appveyor. Ugh.

Current workarounds are:

  • Revert Turf back to 3.7.5
  • Test locally in a browser

Since this may be fixed in @turf/turf v6.x we'll test locally for now and keep issue open.
@dpmcmlxxvi dpmcmlxxvi changed the title Test do not run with PhantomJS. Tests do not run with PhantomJS. Apr 22, 2018
@dpmcmlxxvi dpmcmlxxvi self-assigned this Apr 23, 2018
@dpmcmlxxvi dpmcmlxxvi added the bug label Apr 23, 2018
@dpmcmlxxvi
Copy link
Owner Author

Instead replace with Jest/Puppeteer.

@dpmcmlxxvi
Copy link
Owner Author

Phantomjs has been replaced with Puppeteer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpmcmlxxvi dpmcmlxxvi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dpmcmlxxvi