Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support drafting N cards per pick #1169

Closed
ZeldaZach opened this issue Jul 31, 2020 · 12 comments · Fixed by #1299
Closed

Feature Request: support drafting N cards per pick #1169

ZeldaZach opened this issue Jul 31, 2020 · 12 comments · Fixed by #1299

Comments

@ZeldaZach
Copy link
Member

Detailed Description

With Double Masters, wizards has added that for the first pick of each pack, you get two cards. So it would be 2,1,1,1,...,1 totaling 15 cards selected in 14 picks.

Goal is to support this draft pardim for double masters packs that get drafted.

Stretch goal is A way to allow users to set how many cards per pick (input field would be a list of numbs like I had above)

Further Information

@KainMorgen
Copy link

KainMorgen commented Aug 26, 2020

n-cards per pick becomes even more relevant with Command Legends being announced where you get to pick two cards everytime - not just for the first pick of the draft.

Could be properly implemented by either allowing N selections before showing the autopick option but that would require the script handling picking two or more cards in one pick. Or could be band-aided by not passing the booster to the next player until all N cards of your picks are picked one at a time.

@UlyssesInvictus
Copy link

Hi -- just wondering if this is a feature that's still planned for support in time for Commander Legends (CMR)? I'm a dev myself, so if this is the kind of thing I can help support through PRs, let me know!

@ZeldaZach
Copy link
Member Author

Hey there @UlyssesInvictus if you'd like to contribute a fix for this, it would be greatly appreciated. I'm very swamped with several other projects and don't know if I can get to it this year. If you have any Qs hit us up on Discord (https://mtgjson.com/discord) :)

@lrawicz
Copy link
Contributor

lrawicz commented Nov 8, 2020

working on this

@pyrovoice
Copy link

pyrovoice commented Nov 12, 2020

@lrawicz Any update ? I could also lend a hand if needed

Do you also plan on adding support for a different amount of cards per booster, as Commander Legends is played with 20 cards boosters

@lrawicz
Copy link
Contributor

lrawicz commented Nov 13, 2020

test my code, please

@natron2244
Copy link

I swear I saw this feature available on the site, but seems to be no longer there. Need any help with testing or coding?(Also a follow developer 😉 )

@lrawicz
Copy link
Contributor

lrawicz commented Nov 23, 2020

Haha yes, we had the feature avalible but we roll it back because we found an important bug.

I will fix the bug during the week.

@natron2244
Copy link

@lrawicz awesome to hear, I just found this site/project over! Amazing work! 😄

@LynxDove
Copy link

@lrawicz Hello! Just found Dr4ft.info and Im really impressed. Is there a way for me to find out when you have added multiple picks again? Im relatively new to using github so forgive me if this is a silly question.

@ZeldaZach
Copy link
Member Author

@LynxDove I reverted the change on the dr4ft server, but not the GitHub project itself. When a fix for the multi-pick is re-introduced I'll build master upstream again

@natron2244
Copy link

Awesome work guys! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants