Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The State/Region/County listings for Norway is not correct (administrative reorganization in 2020) #207

Closed
devNoustack opened this issue May 14, 2021 · 11 comments · Fixed by #539
Assignees
Labels
enhancement New feature or request

Comments

@devNoustack
Copy link

First of all, thank you for the time and effort you put into this project! :-)

FYI:

The Norwegian State/Region/County listings is not correct. The Norwegian parliament's reform reduced the number of counties from 19 to 11, which was implemented on 1 January 2020. The new counties is:

Troms og Finnmark
Nordland
Trøndelag
Møre og Romsdal
Vestland
Rogaland
Agder
Vestfold og Telemark
Viken
Oslo og Innlandet

Reference: https://en.wikipedia.org/wiki/Counties_of_Norway

@dr5hn
Copy link
Owner

dr5hn commented May 17, 2021

@devNoustack Thanks for reporting. 🎉

Really appreciated. Will take a look into it soon.

@dr5hn dr5hn self-assigned this May 17, 2021
@dr5hn dr5hn added the enhancement New feature or request label May 17, 2021
@devNoustack
Copy link
Author

Hi again @dr5hn

Do you have an ETA when it can be resolved?

@dr5hn
Copy link
Owner

dr5hn commented Jun 3, 2021

@devNoustack No ETA..

As i see if i merge counties i need to accordingly move cities to proper counties.. and it's gonna take a good amount of time..

If you can help sorting this out by updating states.sql and cities.sql that would be great and raising a pull request.

Thanks

@devNoustack
Copy link
Author

@dr5hn
Copy link
Owner

dr5hn commented Jun 13, 2021

@devNoustack There is a total of 668 cities/town currently in DB and according to your sheet, it's just 107 what about other cities/towns?

@dr5hn
Copy link
Owner

dr5hn commented Oct 30, 2021

Closing this until the next reply.

@dr5hn dr5hn closed this as completed Oct 30, 2021
@braaar
Copy link

braaar commented Jan 17, 2022

Hello there! I am interested in resolving this issue and would be happy to contribute.

Here is an overview over the exact changes that were made 2018-2020:

Old states New, merged state Capital
Hordaland, Sogn og Fjordane Vestland Bergen
Vest-Agder, Aust-Agder  Agder Kristiansand
Sør-Trøndelag, Nord-Trøndelag  Trøndelag Steinkjer
Akershus, Buskerud, Østfold Viken Oslo
Oppland, Hedmark Innlandet Hamar
Troms, Finnmark Troms og Finnmark Tromsø
Vestfold, Telemark Vestfold og Telemark Skien

If I understand the structure of the sql data correctly, this should only be a matter of doing a bunch of Find and Replace operations, and then just reviewing the changes to check for unintentional side effects. I'm not aware of any states in other countries that use these exact names, but then again, we're talking about the whole world here, so there's always a chance.

How are the coordinates for states determined? The location of the capital? Taken from google maps' pin for the state?

@braaar
Copy link

braaar commented Jan 17, 2022

I'll start a PR this week.

@dr5hn
Copy link
Owner

dr5hn commented Jan 22, 2022

@braaar Thanks for showing interest in contributing to the project.

I usually grab the states related information from the official site here. https://www.iso.org/obp/ui/#iso:code:3166:NO

And for coordinates, I search for that location in Google maps, copy the lat and long from the URL and paste it into MySQL Workbench / TablePlus / sequel ace.

Hope that answers your query. 👍🏼

@braaar
Copy link

braaar commented Jan 22, 2022

Thanks for the reply, that is very helpful

@dr5hn dr5hn reopened this Aug 31, 2022
@braaar
Copy link

braaar commented Aug 31, 2022

I probably won't be working on this, so feel free, anyone :)

@braaar braaar removed their assignment Aug 31, 2022
@dr5hn dr5hn linked a pull request Nov 13, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants