Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cambodia does not have state #375

Closed
soeurngsar opened this issue Jan 26, 2022 · 5 comments
Closed

Cambodia does not have state #375

soeurngsar opened this issue Jan 26, 2022 · 5 comments
Assignees

Comments

@soeurngsar
Copy link

For a country like Cambodia, it does not have the state and all the state that you store it just the province.
Some provinces can be called city as well e.g. Battambang province we can call Battambang city also.

Please study this situation and correct it.

Thank for your hard work,

@dr5hn
Copy link
Owner

dr5hn commented Jan 27, 2022

@soeurngsar Thanks for reporting. 🎉

That's a bit tricky to handle. However, the overall goal of the project is to maintain 3 levels of data and discard the 4th level.
Let me know if your findings fit this philosophy.

@soeurngsar
Copy link
Author

Thank for your time, if you want to keep tree level of the data please note that some countries doesn't have state in that case state is empty and move the state level to city level. I'm sure that many countries in ASEAN follow this rules.

@braaar
Copy link

braaar commented Jan 27, 2022

Canada doesn't have states, it has provinces and territories. The state level in this project is used to represent Provinces such as Ontario, British Columbia, etc.

Norway doesn't have states, it has counties. The state level in this project is used to represent counties in Norway like Agder and Nordland.

Cambodia's 24 (de facto 25) provinces seems like a perfect fit for the state category in my view. The province of Battambang belongs in that category just as Battambang city belongs in the city category.

We have the same in Norway, where the capital of Oslo is a county and also a city (it is also a municipality but that level doesn't exist in this project).

It would be very misleading to leave the state level empty for cambodia. The provinces clearly fit into that category just like they do for Canada or Norway.

@dr5hn
Copy link
Owner

dr5hn commented Jan 28, 2022

@soeurngsar We can't leave state-level empty as MySQL is a relational database. We have to maintain a parent-child relationship.

In order to fix this type of issue, we've added a column type in the state. Which justifies what type of record it is.

I think putting them into the states table and filling the type column will justify the data.

https://iso.org/obp/ui/#iso:code:3166:KH

@soeurngsar
Copy link
Author

Ok, thank for your recommendation.
I will follow your rules then.

@dr5hn dr5hn self-assigned this Jan 29, 2022
@dr5hn dr5hn closed this as completed in b1e892c Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants