Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morocco States Mixed with cities #427

Closed
younes-alouani opened this issue Apr 7, 2022 · 2 comments · Fixed by #440
Closed

Morocco States Mixed with cities #427

younes-alouani opened this issue Apr 7, 2022 · 2 comments · Fixed by #440
Assignees

Comments

@younes-alouani
Copy link

Hey dear community,

I'm from Morocco, and I intend to use a database of cities and states of my Countries.
I tried this one, but I found out that many states in the states.csv are indeed cities and not states.
For exemple "Khouribga" is not a state but a city in the state of "Béni-Mellal".

@dr5hn
Copy link
Owner

dr5hn commented May 8, 2022

@younes-alouani Thanks for reporting. 🎉

According to this source it looks correct to me.
https://www.iso.org/obp/ui/#iso:code:3166:MA

Subdivisions
13 prefecture (en) / préfecture (fr) / ‘amālah (ar)
62 province (en) / province (fr) / iqlīm (ar)
12 region (en) / région (fr) / jihāt (ar)

I understand your concern, In this DB we're maintaining only 3 relationships and hence you see Regions and provinces mixed up in the states table.

@dr5hn dr5hn self-assigned this May 8, 2022
@dr5hn dr5hn mentioned this issue May 8, 2022
@dr5hn dr5hn closed this as completed in #440 May 9, 2022
@dr5hn
Copy link
Owner

dr5hn commented May 9, 2022

@younes-alouani To be more precise I have updated the type column under the states table to segregate the types among the states.

Please feel free to reopen this ticket, if you've got any more suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants