Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop DraCor towards a Progressive Web App #136

Open
markschwindt opened this issue Dec 3, 2020 · 4 comments · Fixed by #141
Open

Develop DraCor towards a Progressive Web App #136

markschwindt opened this issue Dec 3, 2020 · 4 comments · Fixed by #141
Assignees

Comments

@markschwindt
Copy link
Member

At the moment DraCor complies with 7 out of 14 PWA requirements:

https://web.dev/pwa-checklist/
Fast and reliable: 0/3; Installable: 1/3; PWA Optimized: 6/8

We could optimise the performance and platform compatibility (android) further to make it more accessible.

@markschwindt
Copy link
Member Author

markschwindt commented Dec 3, 2020

Page load is not fast enough on mobile networks
https://web.dev/load-fast-enough-for-pwa/

Current page does not respond with a 200 when offline
https://web.dev/works-offline/

start_url does not respond with a 200 when offline
https://web.dev/offline-start-url/

Does not register a service worker that controls page and start_url
https://web.dev/service-worker/

Web app manifest does not meet the installability requirements
https://web.dev/installable-manifest/

Is not configured for a custom splash screen
https://web.dev/splash-screen/

Manifest doesn't have a maskable icon
https://web.dev/maskable-icon-audit/

@markschwindt markschwindt self-assigned this Dec 3, 2020
@markschwindt markschwindt linked a pull request Dec 4, 2020 that will close this issue
@cmil cmil closed this as completed in #141 Dec 4, 2020
@cmil cmil reopened this Dec 4, 2020
@cmil
Copy link
Member

cmil commented Dec 4, 2020

The manifest update is a good start, we are now at Fast and reliable: 0/3; Installable: 1/3; PWA Optimized: 7/8. For ticking more boxes we still need to enable the service worker. So Iet's keep this open for now.

@markschwindt markschwindt linked a pull request Dec 5, 2020 that will close this issue
@markschwindt
Copy link
Member Author

markschwindt commented Dec 5, 2020

Got to Fast and reliable: 0/3; Installable: 2/3; PWA Optimized: 8/8

@cmil cmil removed a link to a pull request Dec 5, 2020
@cmil
Copy link
Member

cmil commented Jul 16, 2021

CRA 4 does not include the serviceWorker setup by default anymore because it has some pitfalls. If we still want to go the PWA route here is how to do it: https://create-react-app.dev/docs/making-a-progressive-web-app/#offline-first-considerations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants