Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/Tree window is minimised #4

Closed
SilkAndSlug opened this issue Nov 4, 2019 · 5 comments
Closed

Patch/Tree window is minimised #4

SilkAndSlug opened this issue Nov 4, 2019 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@SilkAndSlug
Copy link

The bottom-right window has minimal width, and thus the list of files can't be seen. The window can be resized. The bottom-right window should show, as per the image on the website.

Capture

@SilkAndSlug
Copy link
Author

There appears to be zero documentation for gitk.

As far as I can see, gitk is writing to ~/.config/git/gitk as it closes, and changing the values of the below params from dracula's defaults. IMHO, gitk is then ignoring the geometry config on load.

$ diff ~/gitk/gitk ./gitk
0a1,18
> set mainfont {sans 9}
> set textfont {monospace 9}
> set uifont {sans 9 bold}
> set tabstop 8
> set findmergefiles 0
> set maxgraphpct 50
> set maxwidth 16
> set cmitmode patch
> set wrapcomment none
> set autoselect 1
> set autosellen 40
> set showneartags 1
> set maxrefs 20
> set visiblerefs {"master"}
> set hideremotes 0
> set showlocalchanges 1
> set datetimeformat {%Y-%m-%d %H:%M:%S}
> set limitdiffs 1
10a29
> set diffcontext 3
13a33,34
> set extdifftool meld
> set perfile_attrs 0
32a54,62
> set geometry(main) 1200x764+0+0
> set geometry(state) normal
> set geometry(topwidth) 1198
> set geometry(topheight) 495
> set geometry(pwsash0) "450 1"
> set geometry(pwsash1) "676 1"
> set geometry(botwidth) 649
> set geometry(botheight) 257
> set permviews {}

I note that, if I delete ~/.config/git/gitk,

  • gitk starts with the bottom pane divided;
  • the gitk file is regenerated when gitk closes; and
  • setting the botwidth in the file (while gitk is closed) sets the size of the bottom pane(s) when gitk restarts.

Looks like Dracula's config breaks gitk.

@lourot lourot added bug Something isn't working help wanted Extra attention is needed labels Nov 10, 2019
@lourot
Copy link
Member

lourot commented Nov 13, 2019

Confirmed: I didn't have any issue before with gitk 2.16.2 on Ubuntu 14.04 but now I have this issue with gitk 2.17.1 on Ubuntu 18.04.

@lourot
Copy link
Member

lourot commented Nov 14, 2019

If you use

set want_ttk 1

instead of 0 then the problem is gone but suddenly not all the GUI looks dark anymore, and you get some of the problems described here, so still no quick solution.

@rmkane
Copy link

rmkane commented May 27, 2020

Having this issue (on Windows 10) also!

@AurelienLourot's solution so enable want_ttk shows the patch tree again.

@lourot
Copy link
Member

lourot commented Jun 18, 2023

The issues preventing us from using set want_ttk 0 have been fixed in

The first version containing this fix is v2.37.0. On Ubuntu for example it's
available starting from Ubuntu 22.10 (Kinetic):
https://packages.ubuntu.com/kinetic/gitk

I have just tried it out and everything works well now for me.

@lourot lourot closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

3 participants