-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colours appears to not be the official HEX values #130
Comments
Are you referring to the colors in the integrated terminal? Because those are set to match the values we have defined in the running spec that were agreed upon after some discussion around terminal readability. |
Also, make sure you don't have "dracula-soft" enabled, which is a variant that we made in vscode because macos renders the colors far too saturated, which many folks stated was too hard on the eyes. |
Thanks for the prompt reply. I don't have dracula-soft enabled, and I didn't mean the terminal colors either -- I meant the actual code editor with standard dracula theme. I'll attach a side-by-side screenshot, with VSCode Dracula on the left, and another editor (Emacs) with the Dracula theme on the right. |
Very strange indeed. So I assume this is likely out of scope then? Is this issue safe to close here? |
True. I'll close this issue as I don't see it as a problem with your repo. Hopefully, someone in the future could find this thread and provide us with a reasonable explanation. |
@dsifford Apparently this is a known bug in Electron: electron/electron#10732 |
Something is wrong here, the Dracula theme on my Visual Studio Code looks just a tiny bit too saturated. And when I checked the HEX values -- sure indeed, the hex codes are not the same as the official colours defined in the Dracula home page. But when I look into your source code (yml file), I noticed that you are indeed using the correct HEX values...
I'm a bit lost here, could it be that vscode applies a sort of colour-filter-layer above my theme?
The text was updated successfully, but these errors were encountered: