Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for symbols (ruby), atoms (elixir) and keys in general #38

Closed
theevangelista opened this issue May 18, 2017 · 3 comments
Closed

Comments

@theevangelista
Copy link

Since symbols, atoms and keys (:foo, bar: "a value", key: :atom) are important part of the languages (ruby, elixir, maybe others?) they could have a dedicated highlight color instead of plain white, which does not provide any relevance for the syntax highlight, e.g.:

Using Code 1.12.2 & Dracula 1.17.0

Elixir:
ex

Ruby:
ruby

Possible Solutions

Atom theme uses the purple color to keys in general such as:

ex-atom

Which would be enough to have.
But since the issue #12 I think would make more sense use the new "keys" highlight as the yaml keys making them more distinguishable.

ruby

@dsifford
Copy link
Member

@joaoevangelista Yep, my thoughts mirror yours. Getting everything uniform is on my todo list.

The plan for now is to make sure all the core languages match the most complete language that I have done (typescript) and then once that's done, I'll probably go in and spot-fix things as needed.

I'm going to probably start a scope->color mapping list in #12 when I get some free time and can commit a good 2-3 hours on it.

Please chime in there with your thoughts/suggestions!

Gonna leave this issue open for now as well because your screenshots are helpful 😄

@dsifford
Copy link
Member

@joaoevangelista Here's what I think the solution is going to come down to....

image

(In case you missed it, I added the pink color to the colon)

In this particular example, I agree that maybe the cyan colored key would look better. But globally, it's a bit too much for non-data languages (e.g. not yaml, json, toml, etc)... The pattern that works best across all files is to make keys the white color and also keep the variables the white color.

Also, while doing that, I noticed quite a handful of issues with the Ruby tmLanguage file (one example being puts isn't scoped to anything, which is strange).

Gonna roll this out when I roll out the big update later this weekend.

@theevangelista
Copy link
Author

Ooooh Yeaaah!! This way with only the colored colon will rock!! Specially when both key and value matches
Thank you for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants