-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a mistake has been found #3
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello! very great project, it gives me a lot help. But I think I found a mistake in model.py, line291, which is 'mupp, logvarpp = self.encoder(xp.detach())'. I suppose that 'xp' should not be detached when updating the parameters of decoder, since it would stop the gradient of backpropagation to decoder, or the generator. Does someone found the same mistake? Thanks, I have given a star.
The text was updated successfully, but these errors were encountered: