Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nydus commit operation #1307

Closed
imeoer opened this issue May 31, 2023 · 3 comments
Closed

support nydus commit operation #1307

imeoer opened this issue May 31, 2023 · 3 comments
Labels

Comments

@imeoer
Copy link
Collaborator

imeoer commented May 31, 2023

For a running container with a nydus image, we can support container commit just like docker commit, the commit operation packs the container writable layer as a new image.

References:

cgroup freezer: https://www.kernel.org/doc/Documentation/cgroup-v1/freezer-subsystem.txt
nerdctl commit: https://github.com/containerd/nerdctl/blob/main/pkg/imgutil/commit/commit.go#L67

We can support it in nydusify commit or nerdctl commit.

@imeoer imeoer added the feature label May 31, 2023
@ywcYY
Copy link

ywcYY commented May 31, 2023

Received, currently interpreting the commit part of the code

@imeoer
Copy link
Collaborator Author

imeoer commented Jan 4, 2024

@PerseidMeteor are working on https://github.com/nydusaccelerator/nydus-cli

@PerseidMeteor
Copy link
Contributor

This issue can closed by #1543

@imeoer imeoer closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants