Better list substitution #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing list substitution, only replace a list name when it is surrounded by whitespace or expected punctuation characters. Lua patterns don't have a notion of this-or-that patterns e.g. (^|abc), so we have 3 versions of the substitution depending on whether he list name occurs in the beginning, middle, or end of a string. This fixes #197.
Add new unit tests to check that list substitution is working as expected, with test cases for the list substitution occurring at the beginning, middle, and end of a condition. Also add tests that verify that overrides on list/macro/rule names always occur in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve list substitution so a list name foo doesn't get inserted into a string my_foo. Also improve some unit tests.