Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some issues with [sidebar background for bookmarks and history when light ff theme is enabled] + [close window button] + [toolbar icon spacing] #18

Closed
ff-o opened this issue Mar 22, 2022 · 4 comments

Comments

@ff-o
Copy link

ff-o commented Mar 22, 2022

Hello,

first of all thank you very much for your work. I love this repo. Exactly what I wanted: sidebars like edge, but much better.
Works great, but I have some minor issues. (Win10, FF 98.0.1).

https://imgur.com/a/rSDoAwt

When I switch to a light firefox theme, the background of the sidebar turns transparent, but only when showing bookmarks or history (no problem when sideberry is selected). No problem with a dark FF theme.

I noticed that the "close window" button seems to be hidden on the far right side, but you can still reach it. I dont' know, if this is intended. Really no big issue, but I can't figure out, how to change this.

There is some weird empty spacing in the toolbar on the far right side, so I can't move the icons to the right side.
Doesn't bother me much, but I would like to know how to change it.

The only changes I made in userchrome.css is enabling @import url("./extensions/fix_hidden_bookmarks.css")

Thanks again

@ff-o ff-o changed the title some issues with [sidebar background for bookmarks and history when light ff theme is enabled] +[close window button] +[toolbar icon spacing] some issues with [sidebar background for bookmarks and history when light ff theme is enabled] + [close window button] + [toolbar icon spacing] Mar 22, 2022
@drannex42
Copy link
Owner

drannex42 commented Mar 22, 2022

That is incredibly strange. I haven't run into this problem. I don't have an answer for 1. But, for 2/3 it appears to be an issue with CSD utility.

I would try modifying the value in prefs.css that handles the client side location, since you are on the right side, I would suggest changing --csd-margin-right: 95px; to about 0px.

@drannex42
Copy link
Owner

drannex42 commented Mar 22, 2022

Just looked again, you have a top bar, I would suggest disabling the csd utility by commenting out that extension in userchrome.css

@ff-o
Copy link
Author

ff-o commented Mar 23, 2022

Hey,
thank you for your quick reply.

Changing csd margin-right to 0px worked for issue 3, and disabling the csd utility worked for 2.
thanks :)q

Issue 1 is no major problem, because I dont change themes often.

@ff-o ff-o closed this as completed Mar 27, 2022
@drannex42
Copy link
Owner

I just released a fix for the transparent background issue. You can find the release here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants