Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues are not shown #44

Closed
vikeri opened this issue May 2, 2016 · 3 comments
Closed

Some issues are not shown #44

vikeri opened this issue May 2, 2016 · 3 comments

Comments

@vikeri
Copy link

vikeri commented May 2, 2016

reagent6, iOS, Mac

TLDR: Some RN errors are not reported anywhere

All of a sudden the hot code reload fails and no more changes are pushed. That usually means that I screwed something up. If I reload the emulator I just get Waiting for Figwheel to load files. The figwheel REPL shows nothing and a (reset-autobuild) successfully recompiles the project.

It is like these issues fall between compile issues shown by figwheel and the red screen of RN. I have not got around to make an MWE but an example issue is when I accidentally ran the function r/adapt-react-class twice on an object.

Not sure if this issue is related to re-natal but I never experienced them in React Web.

@vikeri
Copy link
Author

vikeri commented May 2, 2016

Another kind of issue that will present this behaviour is when (dispatch-sync [:initialize-db]) fails.

@drapanjanas
Copy link
Owner

drapanjanas commented May 2, 2016

Yep, I could reproduce it and fixed. The problem was in case of debugging in chrome erors thrown by importScripts function were not logged at all. No errors logged - no red screen.
I also removed some error messages which did not look very useful. You can just patch your figwheel-bridge.js for now until this fix is released.

@vikeri
Copy link
Author

vikeri commented May 3, 2016

Fix confirmed, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants