Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cut paste undo bug & optimize status bar calc #1353

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Feb 7, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1347
close #1333

Copy link

github-actions bot commented Feb 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (0cd5fdf) 29.64% compared to head (6e88511) 29.99%.
Report is 2 commits behind head on dev.

Files Patch % Lines
...ets-ui/src/services/clipboard/clipboard.service.ts 66.66% 12 Missing ⚠️
...sheets-ui/src/controllers/status-bar.controller.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1353      +/-   ##
==========================================
+ Coverage   29.64%   29.99%   +0.35%     
==========================================
  Files         848      848              
  Lines       48089    48103      +14     
  Branches     9877     9879       +2     
==========================================
+ Hits        14257    14430     +173     
+ Misses      33832    33673     -159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz changed the title fix: cut paste undo bug fix: cut paste undo bug & optimize status bar calc Feb 7, 2024
@DR-Univer
Copy link
Collaborator

image
每次点击鼠标会触发3次status bar统计,mouseup又会触发3次统计

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Some performance issue and code readability issue there.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Feb 19, 2024
@yuhongz yuhongz merged commit 072e0de into dev Feb 19, 2024
7 checks passed
@yuhongz yuhongz deleted the yuhongz/bugfixs-13 branch February 19, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
4 participants