-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cut paste undo bug & optimize status bar calc #1353
Conversation
View Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1353 +/- ##
==========================================
+ Coverage 29.64% 29.99% +0.35%
==========================================
Files 848 848
Lines 48089 48103 +14
Branches 9877 9879 +2
==========================================
+ Hits 14257 14430 +173
+ Misses 33832 33673 -159 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Some performance issue and code readability issue there.
packages/sheets-ui/src/services/clipboard/__tests__/clipboard-service.spec.ts
Outdated
Show resolved
Hide resolved
74fbe14
to
bc53fb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dev
branch.close #1347
close #1333