Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cursor position #1363

Merged
merged 3 commits into from
Feb 18, 2024
Merged

fix: cursor position #1363

merged 3 commits into from
Feb 18, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Feb 18, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1342

@Jocs Jocs changed the title Fix/cursor position fix: cursor position Feb 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Feb 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b289174) 29.75% compared to head (63d5dfc) 29.66%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1363      +/-   ##
==========================================
- Coverage   29.75%   29.66%   -0.10%     
==========================================
  Files         845      848       +3     
  Lines       47931    48081     +150     
  Branches     9832     9872      +40     
==========================================
  Hits        14262    14262              
- Misses      33669    33819     +150

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review February 18, 2024 07:21
@Jocs Jocs requested a review from DR-Univer as a code owner February 18, 2024 07:21
@Jocs Jocs merged commit 34508a0 into dev Feb 18, 2024
7 of 8 checks passed
@Jocs Jocs deleted the fix/cursor-position branch February 18, 2024 07:24
weird94 added a commit that referenced this pull request Jun 28, 2024
@weird94
fix: checkbox formula #1363
022b270
weird94 added a commit that referenced this pull request Jul 1, 2024
@weird94
feat(sheets-data-validation): daily bugfix for data-validation (#2637)
21008f9 
* fix: #1267

* fix: checkbox formula #1363

* fix: checkbox

* fix: data-validation checkbox

* feat: update

* feat: update

* feat: update remove-sheet

* feat: lint

* feat: update

* feat: update

* fix: #1391

* fix: univer-pro #1407

* feat: update sidebar

* fix: code-review issues

* feat: update
weird94 added a commit that referenced this pull request Jul 4, 2024
@weird94 @jikkai
feat(thread-comment): support server intercept for comment & docs-com…
02dff82 
…ment (#2619)

* feat: update

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: update

* feat: delete

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: comment

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: bugfix

* feat: update

* feat: update

* feat: update

* feat: lint

* feat: show filter

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update-ref

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: fix doc copy

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: fix lockfile

* feat: update

* feat: update

* feat: update

* feat: update

* feat: temp

* feat: update

* feat: update

* feat: update

* fix: #1267

* fix: checkbox formula #1363

* fix: checkbox

* fix: data-validation checkbox

* feat: update

* feat: update

* feat: update remove-sheet

* feat: lint

* feat: update

* feat: update

* fix: #1391

* feat: update

* feat: update

* fix: univer-pro #1407

* feat: update

* feat: update

* feat: lint

* feat: update

* feat: update

* feat: update

* feat: update

* feat: reset data

* feat: export commands

* feat: remove console

* fix: lint

---------

Co-authored-by: 白熱 <sonne@asaki.me>
weird94 added a commit that referenced this pull request Jul 5, 2024
@weird94 @jikkai
@scorp1k @DR-Univer @Dushusir
feat(docs-ui): hyper-link support for doc (#2681)
2e80ef0 
* feat: update

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: temp

* feat: update

* feat: delete

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: comment

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: bugfix

* feat: update

* feat: update

* feat: update

* feat: lint

* feat: show filter

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update-ref

* feat: u

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: fix doc copy

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: fix lockfile

* feat: update

* feat: update

* feat: update

* feat: update

* feat: temp

* feat: update

* feat: update

* feat: update

* fix: #1267

* fix: checkbox formula #1363

* fix: checkbox

* fix: data-validation checkbox

* feat: update

* feat: update

* feat: update remove-sheet

* feat: lint

* feat: update

* feat: update

* fix: #1391

* feat: update

* feat: update

* fix: univer-pro #1407

* feat: update

* feat: update

* feat: lint

* feat: update

* feat: update

* feat: update

* feat: update

* feat: reset data

* feat: update doc-hyper-link-plugin

* feat: export commands

* feat: temp

* feat: remove console

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* text: fix test case (#2683)

* fix: add correct RU translation in Sort and Hyperlink plugins (#2685)

* feat: lock

* fix(sheet): drawing switch tab position error (#2686)

* feat: fix hyperlink copy

* feat: update

* feat: update

* feat(formula): add asin function (#2620)

* feat(formula): add asin function

* feat(formula): add asinh function

* feat(formula): add tan,tanh functions

* test(formula): acot test

* fix(formula): function atan2 calculation

* fix(sheet): strip every number cell

* fix(sheet): remove unused module

* fix(sheet): skip numfmt pattern in number cell interceptor

* feat: update

* feat: update

* ci: fix ci (#2687)

* feat: fix update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* feat: update

* fix: update

* fix: update

* feat: update

* feat: update

* feat: update

* fix: eslint

* feat: update

* feat: rename

* feat: update

* feat: update

* feat: update

* feat: update

---------

Co-authored-by: 白熱 <sonne@asaki.me>
Co-authored-by: scorp1k <65504800+scorp1k@users.noreply.github.com>
Co-authored-by: Univer <68851825+DR-Univer@users.noreply.github.com>
Co-authored-by: Dushusir <1414556676@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gggpound Gggpound Gggpound approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] the cursor position is wrong when input quickly
2 participants
@Jocs @Gggpound