Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): copy form univer text and paste to univer #1473

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 4, 2024

  • I am sure that the code is update-to-date with the dev branch.

  • Rewrite IDocumentBody to Html algo.
  • Add more tests.

close #1426

@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 32.70%. Comparing base (271574a) to head (871aa55).

Files Patch % Lines
...ipboard/html-to-udm/paste-plugins/plugin-univer.ts 0.00% 14 Missing ⚠️
...ui/src/services/clipboard/udm-to-html/convertor.ts 82.35% 9 Missing ⚠️
...ocs-ui/src/services/clipboard/html-to-udm/utils.ts 0.00% 4 Missing ⚠️
...services/clipboard/html-to-udm/parse-node-style.ts 0.00% 2 Missing ⚠️
...ocs-ui/src/services/clipboard/clipboard.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1473      +/-   ##
==========================================
+ Coverage   32.67%   32.70%   +0.02%     
==========================================
  Files         906      907       +1     
  Lines       50465    50502      +37     
  Branches    10520    10533      +13     
==========================================
+ Hits        16491    16516      +25     
- Misses      33974    33986      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs changed the title fix: copy form univer text and paste to univer fix(doc): copy form univer text and paste to univer Mar 5, 2024
@Jocs Jocs marked this pull request as ready for review March 5, 2024 03:43
@Jocs Jocs requested a review from jikkai as a code owner March 5, 2024 03:43
@zhaolixin7
Copy link

@Jocs 粘贴后行间距未保留预期应该也要支持的?
image

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@Jocs Jocs force-pushed the fix/copy-paste branch from 5aa83f2 to 9aadeb4 Compare March 6, 2024 11:33
@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 6, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 6, 2024
@Jocs Jocs requested review from wzhudev and DR-Univer March 7, 2024 06:36
Copy link
Contributor

@yuhongz yuhongz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
I will modify the SHEET part of Univer, taking inspiration from your implementation.

@Jocs Jocs merged commit 4f3ab13 into dev Mar 7, 2024
7 checks passed
@Jocs Jocs deleted the fix/copy-paste branch March 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 复制内容后粘贴格式未保留(字号、字体格式、行间距)
3 participants