Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): inline format menu display error when paste #1482

Merged
merged 2 commits into from
Mar 15, 2024
Merged

fix(sheet): inline format menu display error when paste #1482

merged 2 commits into from
Mar 15, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1412

@Jocs Jocs marked this pull request as ready for review March 5, 2024 07:33
@Jocs Jocs requested review from jikkai and wzhudev as code owners March 5, 2024 07:33
@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 32.78%. Comparing base (271574a) to head (4a97c91).
Report is 56 commits behind head on dev.

Files Patch % Lines
packages/core/src/sheets/range.ts 0.00% 6 Missing ⚠️
packages/sheets-ui/src/controllers/menu/menu.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1482      +/-   ##
==========================================
+ Coverage   32.67%   32.78%   +0.10%     
==========================================
  Files         906      913       +7     
  Lines       50465    50807     +342     
  Branches    10520    10593      +73     
==========================================
+ Hits        16491    16656     +165     
- Misses      33974    34151     +177

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7
Copy link

@Jocs 粘贴后格式未保留（加粗），工具栏格字号不对
2024_3_5 17_40_28 commands.json
2024_3_5 17_40_28 video.webm

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Mar 5, 2024
@Jocs Jocs requested a review from DR-Univer as a code owner March 8, 2024 13:11
@Jocs Jocs added qa:untested This PR is ready to be tested and removed qa:rejected labels Mar 8, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 15, 2024
wzhudev
wzhudev reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wzhudev
wzhudev approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit c66f9e1 into dev Mar 15, 2024
7 checks passed
@wzhudev wzhudev deleted the fix/copy-paste-in-cell branch March 15, 2024 05:05
ybzky pushed a commit that referenced this pull request Mar 19, 2024
@Jocs
fix(sheet): inline format menu display error when paste (#1482)
836bec4 
* fix(sheet): inline format menu display error when paste

* fix: font size menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
3 participants
@Jocs @zhaolixin7 @wzhudev