Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix layout service throwing error #1490

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 5, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1489

@wzhudev wzhudev requested review from jikkai and Jocs as code owners March 5, 2024 14:26
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 32.78%. Comparing base (5781a63) to head (674d391).
Report is 3 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/layout/layout.service.ts 0.00% 2 Missing ⚠️
...kages/docs-ui/src/controllers/doc-ui.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1490      +/-   ##
==========================================
+ Coverage   32.76%   32.78%   +0.02%     
==========================================
  Files         905      905              
  Lines       50202    50244      +42     
  Branches    10457    10469      +12     
==========================================
+ Hits        16451    16475      +24     
- Misses      33751    33769      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 6, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 6, 2024
@wzhudev wzhudev merged commit c2ee6d2 into dev Mar 6, 2024
7 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-layout-service-handler-missing branch March 6, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 退出禅模式控制台报错
3 participants