Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): border excel compatibility #1539

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 11, 2024

https://github.com/dream-num/univer-pro/issues/344

  • Compatible with Excel's border rendering.
    When the top border of a cell and the bottom border of the cell above it (r-1) overlap, if the top border of cell r is white, then the rendering is ignored.

close #

@DR-Univer DR-Univer requested a review from wzhudev as a code owner March 11, 2024 06:59
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 11, 2024
Copy link

github-actions bot commented Mar 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 32.91%. Comparing base (6123772) to head (483343f).

Files Patch % Lines
packages/core/src/shared/color/color-kit.ts 0.00% 34 Missing ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1539      +/-   ##
==========================================
- Coverage   32.93%   32.91%   -0.03%     
==========================================
  Files         919      919              
  Lines       51089    51135      +46     
  Branches    10628    10642      +14     
==========================================
+ Hits        16825    16829       +4     
- Misses      34264    34306      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit d68896a into dev Mar 11, 2024
8 checks passed
@DR-Univer DR-Univer deleted the fix-border-excel-compatibility branch March 11, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant