Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(engine-render): optimize border perf #1574

Merged
merged 6 commits into from
Mar 23, 2024
Merged

perf(engine-render): optimize border perf #1574

merged 6 commits into from
Mar 23, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Mar 14, 2024 •
edited by DR-Univer
Loading

  • I am sure that the code is update-to-date with the dev branch.

close #1645

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 32.91%. Comparing base (f30b987) to head (ca91efa).
Report is 7 commits behind head on dev.

Files Patch % Lines
...engine-render/src/components/sheets/spreadsheet.ts 0.00% 22 Missing ⚠️
packages/engine-render/src/context.ts 0.00% 8 Missing ⚠️
packages/engine-render/src/basics/draw.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1574      +/-   ##
==========================================
- Coverage   32.92%   32.91%   -0.02%     
==========================================
  Files         934      934              
  Lines       52498    52518      +20     
  Branches    11011    11008       -3     
==========================================
  Hits        17286    17286              
- Misses      35212    35232      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wzhudev
wzhudev reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev changed the title feat(engine-render): optimize border perf perf(engine-render): optimize border perf Mar 14, 2024
@weird94 weird94 added the qa:untested This PR is ready to be tested label Mar 15, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 23, 2024
@weird94 weird94 merged commit 0aa2898 into dev Mar 23, 2024
8 checks passed
@weird94 weird94 deleted the feat/border-perf branch March 23, 2024 03:36
Jocs pushed a commit that referenced this pull request Mar 23, 2024
@weird94 @DR-Univer @Jocs
perf(engine-render): optimize border perf (#1574)
bbb6ceb 
* feat: optimize border perf

* feat: row count to 100w

* fix: border perf

* feat: 100w lines

* fix(render): mac render border failed

---------

Co-authored-by: DR-Univer <wbfsa@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev left review comments

@DR-Univer DR-Univer DR-Univer approved these changes

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Slide to the bottom, some data is missing , Sliding stuck
4 participants
@weird94 @wzhudev @DR-Univer @zhaolixin7