fix(sheets): boolean should store as number #1605
Merged
+45
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #1534 BREAKING CHANGE: Before: Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData as strings. After: Boolean values would be store as number (0, 1).
|
@zhaolixin7 Please verify that Boolean values ( |
View Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1605 +/- ##
==========================================
- Coverage 32.42% 32.38% -0.05%
==========================================
Files 923 924 +1
Lines 52174 52182 +8
Branches 10896 10893 -3
==========================================
- Hits 16920 16897 -23
- Misses 35254 35285 +31 ☔ View full report in Codecov by Sentry. |
wzhudev
force-pushed
the
wzhudev/refactor-boolean-store-as-number
branch
from
49fdb85 to
aa83aeb
Compare
Dushusir
reviewed
Mar 16, 2024
| @@ -57,6 +57,7 @@ import { | |||
|
|
|||
| import { Inject } from '@wendellhu/redi'; | |||
| import { distinctUntilChanged, startWith } from 'rxjs'; | |||
| import { extractPureTextFromCell } from '@univerjs/core/sheets/worksheet.js'; | |||
Dushusir
approved these changes
Mar 16, 2024
DR-Univer
approved these changes
Mar 16, 2024
ybzky
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix(sheets): boolean should store as number close #1534 BREAKING CHANGE: Before: Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData as strings. After: Boolean values would be store as number (0, 1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1534
BREAKING CHANGE:
Before:
Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData as strings.
After:
Boolean values would be store as number (0, 1).
devbranch.