Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(doc): continuous punctuation extrusion and paragraph align #1625

Merged
merged 17 commits into from
Mar 23, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 18, 2024

  • First and last line prohibition (already supported in linebreak, just need to verify)
  • Adjustment of continuous punctuation marks
  • punctuation extrusion at the start or end of the line
  • hanging punctuation at the end of the line
  • Mixed Chinese and Western text (this has been implemented before, and needs to be adjusted and optimized according to this requirement)
  • Paragraph justify
  • Paragraph align menus

close #1626

@zhaolixin7 need to test paragraph align menus and its functions.

Copy link

github-actions bot commented Mar 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 5.17241% with 330 lines in your changes are missing coverage. Please review.

Project coverage is 32.82%. Comparing base (0aa2898) to head (eeb5d4a).

Files Patch % Lines
...nts/docs/layout/block/paragraph/line-adjustment.ts 0.00% 119 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 74 Missing ⚠️
...s/src/commands/commands/paragraph-align.command.ts 0.00% 47 Missing ⚠️
...ocs/src/commands/commands/inline-format.command.ts 17.64% 42 Missing ⚠️
.../components/docs/layout/block/paragraph/shaping.ts 0.00% 33 Missing ⚠️
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 7 Missing ⚠️
...e-render/src/components/docs/layout/model/glyph.ts 81.81% 2 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 2 Missing ⚠️
...ackages/docs/src/commands/commands/list.command.ts 0.00% 1 Missing ⚠️
packages/docs/src/doc-plugin.ts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1625      +/-   ##
==========================================
- Coverage   32.94%   32.82%   -0.12%     
==========================================
  Files         946      947       +1     
  Lines       52843    53105     +262     
  Branches    11047    11088      +41     
==========================================
+ Hits        17408    17434      +26     
- Misses      35435    35671     +236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs force-pushed the feat/punctuation_adjustment branch 2 times, most recently from c26f57e to 2195f2a Compare March 20, 2024 13:03
@Jocs Jocs marked this pull request as ready for review March 20, 2024 13:26
@Jocs Jocs requested review from DR-Univer and wzhudev as code owners March 20, 2024 13:26
@Jocs Jocs requested a review from jikkai as a code owner March 21, 2024 12:07
@Jocs Jocs marked this pull request as draft March 21, 2024 12:26
@Jocs Jocs marked this pull request as ready for review March 21, 2024 13:21
@Jocs Jocs added the qa:untested This PR is ready to be tested label Mar 21, 2024
@Jocs Jocs changed the title feat(doc): continuous punctuation extrusion feat(doc): continuous punctuation extrusion and paragraph align Mar 22, 2024
@Jocs Jocs force-pushed the feat/punctuation_adjustment branch from be8450f to d74c1f9 Compare March 23, 2024 05:25
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 23, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 23, 2024
@Jocs Jocs merged commit b50997d into dev Mar 23, 2024
8 checks passed
@Jocs Jocs deleted the feat/punctuation_adjustment branch March 23, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quick Ticket] Punctuation adjustment
4 participants