feat(sheets): add watch API to ref-range-service #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1635 +/- ##
==========================================
+ Coverage 29.90% 29.96% +0.06%
==========================================
Files 1162 1162
Lines 62963 63095 +132
Branches 13232 13268 +36
==========================================
+ Hits 18826 18909 +83
- Misses 44137 44186 +49 ☔ View full report in Codecov by Sentry. |
74 tasks
wzhudev
commented
Apr 10, 2024
| @@ -0,0 +1,435 @@ | |||
| /** | |||
There was a problem hiding this comment.
Be careful with the file's name. It should be in kebab-case.
| @@ -64,6 +103,38 @@ export class RefRangeService extends Disposable { | |||
| }); | |||
| } | |||
|
|
|||
| watchRange(unitId: string, subUnitId: string, range: IRange, callback: WatchRangeCallback): IDisposable { | |||
There was a problem hiding this comment.
This API seems not tested.
wzhudev
force-pushed
the
wzhudev/feat-watch-range-change
branch
from
f0b3180
to
0ad7202
Compare
View Deployment
|
wzhudev
force-pushed
the
wzhudev/feat-watch-range-change
branch
from
2262545
to
10eda64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #xxx, #yyy, #zzzz