Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide): slide initialize #1641

Merged
merged 12 commits into from
Mar 21, 2024
Merged

fix(slide): slide initialize #1641

merged 12 commits into from
Mar 21, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #xxx, #yyy, #zzzz

@DR-Univer DR-Univer marked this pull request as ready for review March 20, 2024 16:24
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 5.88235% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 32.92%. Comparing base (f4d6bd1) to head (cb8a496).

Files Patch % Lines
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 21 Missing ⚠️
packages/engine-render/src/layer.ts 0.00% 10 Missing ⚠️
packages/engine-render/src/engine.ts 0.00% 6 Missing ⚠️
packages/engine-render/src/scene.ts 0.00% 6 Missing ⚠️
...ges/core/src/services/instance/instance.service.ts 50.00% 5 Missing ⚠️
packages/engine-render/src/shape/shape.ts 0.00% 5 Missing ⚠️
...s/sheets-ui/src/controllers/sheet-ui.controller.ts 0.00% 5 Missing ⚠️
packages/core/src/slides/domain/slide-model.ts 0.00% 4 Missing ⚠️
packages/engine-render/src/scene-viewer.ts 0.00% 4 Missing ⚠️
packages/core/src/basics/univer-slide.ts 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1641      +/-   ##
==========================================
+ Coverage   32.91%   32.92%   +0.01%     
==========================================
  Files         934      934              
  Lines       52514    52496      -18     
  Branches    11012    11011       -1     
==========================================
  Hits        17286    17286              
+ Misses      35228    35210      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Mar 21, 2024
@wzhudev wzhudev merged commit 599ed71 into dev Mar 21, 2024
8 checks passed
@wzhudev wzhudev deleted the fix-slide-plugin branch March 21, 2024 03:24
Jocs pushed a commit that referenced this pull request Mar 23, 2024

---------

Co-authored-by: Wenzhao Hu <wzhudev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants