Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slide): image loaded #1653

Merged
merged 3 commits into from
Mar 21, 2024
Merged

fix(slide): image loaded #1653

merged 3 commits into from
Mar 21, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Mar 21, 2024 •
edited
Loading

  • refresh thumb on image loaded
  • document scroll disappear

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 21, 2024
@DR-Univer DR-Univer changed the title fix:(slide) image loaded fix(slide): image loaded Mar 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 32.92%. Comparing base (599ed71) to head (9ac7df9).

Files Patch % Lines
...ages/engine-render/src/components/docs/document.ts 0.00% 3 Missing ⚠️
packages/engine-render/src/base-object.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/shape/picture.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/thin-scene.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1653      +/-   ##
==========================================
- Coverage   32.92%   32.92%   -0.01%     
==========================================
  Files         934      934              
  Lines       52496    52498       +2     
  Branches    11011    11011              
==========================================
  Hits        17286    17286              
- Misses      35210    35212       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 9cecaaa into dev Mar 21, 2024
7 of 8 checks passed
@DR-Univer DR-Univer deleted the fix-slide-image-loaded branch March 21, 2024 07:29
Jocs pushed a commit that referenced this pull request Mar 23, 2024
@DR-Univer @Jocs
fix(slide): image loaded (#1653)
24d47f0 
* fix(slide): image loaded for thumb

* fix(doc): scroll disappear

* fix(slide): null checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev Awaiting requested review from wzhudev

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

Assignees
No one assigned
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DR-Univer