Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): short key error #1679

Merged
merged 2 commits into from
Mar 23, 2024
Merged

fix(editor): short key error #1679

merged 2 commits into from
Mar 23, 2024

Conversation

DR-Univer
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Mar 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 32.80%. Comparing base (a875a31) to head (c8a51b7).
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/editor/editor.service.ts 0.00% 5 Missing ⚠️
...kages/sheets-ui/src/controllers/shortcuts/utils.ts 0.00% 2 Missing ⚠️
packages/docs-ui/src/shortcuts/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1679      +/-   ##
==========================================
+ Coverage   32.75%   32.80%   +0.05%     
==========================================
  Files         951      952       +1     
  Lines       53329    53390      +61     
  Branches    11129    11145      +16     
==========================================
+ Hits        17466    17513      +47     
- Misses      35863    35877      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit 7afaff0 into dev Mar 23, 2024
8 checks passed
@jikkai jikkai deleted the fix-editor-short-key-error branch July 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant