Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display error in font family #1700

Merged
merged 3 commits into from
Apr 10, 2024
Merged

fix: display error in font family #1700

merged 3 commits into from
Apr 10, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 26, 2024 •
edited
Loading

close #1701

@Jocs Jocs marked this pull request as ready for review March 26, 2024 08:26
@Jocs Jocs requested review from jikkai and wzhudev as code owners March 26, 2024 08:26
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.90%. Comparing base (a475474) to head (3f2a03a).

Files Patch % Lines
...kages/ui/src/components/font-family/FontFamily.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1700      +/-   ##
==========================================
- Coverage   29.90%   29.90%   -0.01%     
==========================================
  Files        1162     1162              
  Lines       62957    62961       +4     
  Branches    13231    13232       +1     
==========================================
  Hits        18826    18826              
- Misses      44131    44135       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jikkai
jikkai requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try useMemo.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 1, 2024
@Jocs Jocs force-pushed the fix/display-font-family branch from 960f218 to ce6c309 Compare April 10, 2024 02:49
jikkai
jikkai approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit 8c2282b into dev Apr 10, 2024
8 checks passed
@jikkai jikkai deleted the fix/display-font-family branch April 10, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai jikkai approved these changes

@wzhudev wzhudev Awaiting requested review from wzhudev

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] font family name is not display correctly after copy and paste
3 participants
@Jocs @jikkai @zhaolixin7