Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): set-tab-order-mutation should has fromIndex in parmas for transforming #1704

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Mar 26, 2024

close #xxx, #yyy, #zzzz

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 26, 2024
@yuhongz yuhongz requested a review from Dushusir March 26, 2024 10:01
Copy link

View Deployment

#8434080029

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.33%. Comparing base (1ebfe1a) to head (474ff06).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1704      +/-   ##
==========================================
- Coverage   32.34%   32.33%   -0.01%     
==========================================
  Files         976      976              
  Lines       54155    54152       -3     
  Branches    11284    11284              
==========================================
- Hits        17514    17511       -3     
  Misses      36641    36641              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz changed the title fix: set-tab-order-mutation should has fromIndex in parmas for transforming fix(sheet): set-tab-order-mutation should has fromIndex in parmas for transforming Mar 26, 2024
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Mar 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Mar 26, 2024
@wzhudev wzhudev merged commit 6d05bd9 into dev Mar 26, 2024
9 checks passed
@wzhudev wzhudev deleted the yuhongz/fix-settaborder branch March 26, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants