Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets): fix the issue where the editor position is incorrect after unmerging cells #1717

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Mar 27, 2024

…ging cells

close #1205

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 27, 2024
Copy link

github-actions bot commented Mar 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 29.69%. Comparing base (02e9647) to head (70eb2de).
Report is 38 commits behind head on dev.

Files Patch % Lines
...ommands/commands/remove-worksheet-merge.command.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1717      +/-   ##
==========================================
- Coverage   32.33%   29.69%   -2.64%     
==========================================
  Files         976     1139     +163     
  Lines       54168    61930    +7762     
  Branches    11291    12963    +1672     
==========================================
+ Hits        17513    18392     +879     
- Misses      36655    43538    +6883     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai changed the title fix: fix the issue where the editor position is incorrect after unmer… fix(sheets): fix the issue where the editor position is incorrect after unmerging cells Mar 28, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 1, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 1, 2024
@wzhudev wzhudev requested a review from yuhongz April 2, 2024 01:46
@ybzky ybzky requested a review from wzhudev April 2, 2024 11:14
@wzhudev wzhudev merged commit 7d27f11 into dev Apr 7, 2024
8 checks passed
@wzhudev wzhudev deleted the fix-remove-merge-selection branch April 7, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 合并、取消合并单元格后,编辑框大小不对
3 participants