Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): backspace will cause error when doc is not ready #1725

Merged
merged 3 commits into from
Mar 29, 2024
Merged

fix(doc): backspace will cause error when doc is not ready #1725

merged 3 commits into from
Mar 29, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 28, 2024 •
edited
Loading

close #1726

@Jocs Jocs marked this pull request as ready for review March 28, 2024 13:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Mar 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 28, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 31.62%. Comparing base (83d910c) to head (e1dbd95).
Report is 1 commits behind head on dev.

Files Patch % Lines
...onents/docs/layout/block/paragraph/layout-ruler.ts 0.00% 13 Missing ⚠️
packages/engine-render/src/basics/font-cache.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1725   +/-   ##
=======================================
  Coverage   31.62%   31.62%           
=======================================
  Files        1044     1044           
  Lines       57883    57883           
  Branches    12170    12170           
=======================================
  Hits        18305    18305           
  Misses      39578    39578

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wzhudev
wzhudev approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jocs Jocs removed the qa:untested This PR is ready to be tested label Mar 29, 2024
@Jocs Jocs merged commit f24fdb1 into dev Mar 29, 2024
8 checks passed
@Jocs Jocs deleted the fix/inner-cut branch March 29, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Press backspace will cause error when doc is not ready
2 participants
@Jocs @wzhudev