Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facade): fix set horizontal, vertical, warp #1766

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Apr 2, 2024

fix facade

  • range.setVerticalAlignment
  • range.setHorizontalAlignment
  • range.setWrap
  • range.setWrapStrategy

@hexf00 hexf00 requested review from wzhudev and DR-Univer as code owners April 2, 2024 07:42
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
@hexf00 hexf00 removed the qa:untested This PR is ready to be tested label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.68%. Comparing base (436b1b4) to head (ae1e3f3).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1766      +/-   ##
==========================================
+ Coverage   29.65%   29.68%   +0.02%     
==========================================
  Files        1138     1138              
  Lines       61865    61865              
  Branches    12940    12940              
==========================================
+ Hits        18349    18366      +17     
+ Misses      43516    43499      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexf00 hexf00 requested a review from Dushusir April 2, 2024 07:50
@hexf00 hexf00 force-pushed the fix/fix-facade-set-horizontal-and-vertical branch from 32e61a8 to ae1e3f3 Compare April 2, 2024 08:55
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 2, 2024
@hexf00 hexf00 changed the title fix(facade): fix set horizontal and vertical fix(facade): fix set horizontal, vertical, warp Apr 2, 2024
@jikkai jikkai removed the qa:untested This PR is ready to be tested label Apr 2, 2024
@jikkai jikkai merged commit 1876e68 into dev Apr 2, 2024
11 checks passed
@jikkai jikkai deleted the fix/fix-facade-set-horizontal-and-vertical branch April 2, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants