Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sheets-ui): sheet popup service should respond to row col changes #1848

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 10, 2024

No description provided.

Copy link

github-actions bot commented Apr 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 29.96%. Comparing base (337af7d) to head (a2a75e9).

Files Patch % Lines
...eets-ui/src/services/canvas-pop-manager.service.ts 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1848      +/-   ##
==========================================
- Coverage   29.96%   29.96%   -0.01%     
==========================================
  Files        1162     1162              
  Lines       63095    63096       +1     
  Branches    13267    13265       -2     
==========================================
  Hits        18909    18909              
- Misses      44186    44187       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 6868a47 into dev Apr 10, 2024
8 checks passed
@wzhudev wzhudev deleted the feat/popup-ref-range branch April 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants