Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): ensure popup component is appended to root to prevent offset from stacking contexts #1850

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jikkai
Copy link
Member

@jikkai jikkai commented Apr 10, 2024

@jikkai jikkai requested review from wzhudev and Jocs as code owners April 10, 2024 08:33
Copy link

github-actions bot commented Apr 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.96%. Comparing base (6868a47) to head (340855a).

Files Patch % Lines
packages/design/src/components/popup/Popup.tsx 0.00% 2 Missing ⚠️
packages/ui/src/components/editor/TextEditor.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1850      +/-   ##
==========================================
- Coverage   29.96%   29.96%   -0.01%     
==========================================
  Files        1162     1162              
  Lines       63096    63097       +1     
  Branches    13265    13265              
==========================================
  Hits        18909    18909              
- Misses      44187    44188       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit 1ad518a into dev Apr 10, 2024
9 checks passed
@jikkai jikkai deleted the fix/popup branch April 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The formula panel is not aligned.
2 participants