Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheets-data-validation): fix typescript error #1858

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Apr 10, 2024

close #xxx, #yyy, #zzzz

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 10, 2024
Copy link

github-actions bot commented Apr 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@jikkai jikkai removed the qa:untested This PR is ready to be tested label Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 29.95%. Comparing base (6256c15) to head (ccb8ae2).

Files Patch % Lines
...alidation/src/services/dropdown-manager.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1858      +/-   ##
==========================================
- Coverage   29.95%   29.95%   -0.01%     
==========================================
  Files        1163     1163              
  Lines       63128    63129       +1     
  Branches    13271    13272       +1     
==========================================
  Hits        18911    18911              
- Misses      44217    44218       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jikkai jikkai merged commit b8007cb into dev Apr 10, 2024
8 checks passed
@jikkai jikkai deleted the fix/canvas-pop-up-ts branch April 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants