Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheets): the text is aligned at editorial and non-editorial states #1874

Merged
merged 3 commits into from
Apr 13, 2024
Merged

fix(sheets): the text is aligned at editorial and non-editorial states #1874

merged 3 commits into from
Apr 13, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Apr 11, 2024 •
edited
Loading

close #1744

@Jocs Jocs changed the title fix(sheets): Editorial and non-editorial states, the text is aligned fix(sheets): the text is aligned at editorial and non-editorial states Apr 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 29.58%. Comparing base (f80ed5d) to head (c7f912d).

Files Patch % Lines
...ui/src/controllers/editor/start-edit.controller.ts 0.00% 5 Missing ⚠️
.../docs-ui/src/controllers/page-render.controller.ts 0.00% 2 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 2 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1874      +/-   ##
==========================================
- Coverage   29.58%   29.58%   -0.01%     
==========================================
  Files        1165     1165              
  Lines       63239    63241       +2     
  Branches    13312    13312              
==========================================
  Hits        18707    18707              
- Misses      44532    44534       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs Jocs marked this pull request as ready for review April 11, 2024 17:50
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 11, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 12, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 12, 2024
wzhudev
wzhudev approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit c7e26a0 into dev Apr 13, 2024
8 checks passed
@wzhudev wzhudev deleted the fix/cell-font-render branch April 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The editor cannot be aligned with the text of the cell after it is opened.
3 participants
@Jocs @wzhudev @zhaolixin7