-
-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permission): support permission #1931
Conversation
View Deployment
|
725ee2e
to
fccaed3
Compare
7d2f8eb
to
babc5c2
Compare
8f6df5c
to
24fa756
Compare
1afae29
to
18c668c
Compare
packages/sheets/src/services/permission/worksheet-permission/protect-background-img.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/views/error-msg-dialog/index.module.less
Show resolved
Hide resolved
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
packages/sheets-selection-protection/src/selection-protection-plugin.ts
Outdated
Show resolved
Hide resolved
...eets-selection-protection/src/service/selection-protection/selection-protection.ref-range.ts
Outdated
Show resolved
Hide resolved
packages/sheets-selection-protection/src/model/selection-protection-render.model.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few headsup:
- Please follow our naming convention.
- Please avoid exposing methods or properties that are not called by outside code
825c215
to
3551c38
Compare
8c826ba
to
1746849
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some code readability issue need to be addressed.
packages/debugger/src/commands/operations/set.editable.operation.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/command/range-protection.command.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
packages/sheet-permission-ui/src/controller/sheet-permission.interceptor.controller.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #540