Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): header hidden #1954

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix(sheet): header hidden #1954

merged 1 commit into from
Apr 17, 2024

Conversation

DR-Univer
Copy link
Collaborator

close #1933

@DR-Univer DR-Univer requested a review from wzhudev as a code owner April 17, 2024 11:06
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 17, 2024
Copy link

github-actions bot commented Apr 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.78%. Comparing base (e921128) to head (6e7d71a).
Report is 2 commits behind head on dev.

Files Patch % Lines
.../components/sheets/extensions/row-header-layout.ts 0.00% 3 Missing ⚠️
...mponents/sheets/extensions/column-header-layout.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1954      +/-   ##
==========================================
- Coverage   29.78%   29.78%   -0.01%     
==========================================
  Files        1173     1173              
  Lines       64014    64032      +18     
  Branches    13599    13605       +6     
==========================================
  Hits        19069    19069              
- Misses      44945    44963      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit e3dc9ce into dev Apr 17, 2024
7 of 8 checks passed
@DR-Univer DR-Univer deleted the fix-slide-and-sheet-header branch April 17, 2024 12:38
Gggpound pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The rowHeader and columnHeader are not hidden
2 participants