Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix non-sheet renderer should not be set container #2044

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 23, 2024

No description provided.

@wzhudev wzhudev requested review from jikkai and Jocs as code owners April 23, 2024 03:32
Copy link

github-actions bot commented Apr 23, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 29.60%. Comparing base (6ac331c) to head (4161133).

❗ Current head 4161133 differs from pull request most recent head 3fbb512. Consider uploading reports for the commit 3fbb512 to get more accurate results

Files Patch % Lines
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2044      +/-   ##
==========================================
- Coverage   29.60%   29.60%   -0.01%     
==========================================
  Files        1182     1182              
  Lines       64334    64337       +3     
  Branches    13627    13628       +1     
==========================================
  Hits        19045    19045              
- Misses      45289    45292       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 00b30e5 into dev Apr 23, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-render-container branch April 23, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants