Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): fix close ui plugin config and focus capturing #2086

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(ui): fix close ui plugin config and focus capturing #2086

merged 2 commits into from
Apr 26, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 26, 2024 •
edited
Loading

close #1914

close #1967

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Apr 26, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (f07c2d9) to head (19ed3af).
Report is 1 commits behind head on dev.

Files Patch % Lines
packages/ui/src/services/layout/layout.service.ts 0.00% 5 Missing ⚠️
packages/ui/src/ui-plugin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2086   +/-   ##
=======================================
  Coverage   31.04%   31.04%           
=======================================
  Files        1207     1207           
  Lines       66151    66151           
  Branches    13993    13993           
=======================================
  Hits        20534    20534           
  Misses      45617    45617

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev changed the title fix(ui): fix close ui plugin config fix(ui): fix close ui plugin config and focus capturing Apr 26, 2024
@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Apr 26, 2024
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Apr 26, 2024
@wzhudev wzhudev merged commit 4a360f7 into dev Apr 26, 2024
11 checks passed
@wzhudev wzhudev deleted the fix/disable-auto-focus branch April 26, 2024 07:23
Dushusir pushed a commit that referenced this pull request Apr 26, 2024
@wzhudev @Dushusir
fix(ui): fix close ui plugin config and focus capturing (#2086)
e89978a 
* fix(ui): fix close ui plugin config

close #1914

* fix(ui): fix focus on canvas element is not regained

close #1967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees

@zhaolixin7 zhaolixin7

Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
2 participants
@wzhudev @zhaolixin7