fix: skeleton change will remove autofill popupmenu #2092
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2092 +/- ##
==========================================
+ Coverage 31.04% 31.05% +0.01%
==========================================
Files 1207 1207
Lines 66151 66183 +32
Branches 13993 13995 +2
==========================================
+ Hits 20534 20556 +22
- Misses 45617 45627 +10 ☔ View full report in Codecov by Sentry. |
View Deployment
|
| @@ -97,6 +97,16 @@ export const AutoFillPopupMenu: React.FC<{}> = () => { | |||
| return disposable.dispose; | |||
| }, [forceUpdate, commandService]); | |||
|
|
|||
| useEffect(() => { | |||
| const disposable = toDisposable( | |||
| sheetSkeletonManagerService.currentSkeleton$.subscribe((skeleton) => { | |||
There was a problem hiding this comment.
引起 skeleton change 的事件有很多，确认都要关闭吗？协同场景下会不会有问题？
There was a problem hiding this comment.
确实，协同带来的 skeleton change 应该只刷新位置，不会导致按钮关闭。这里我把它改成监听一些本地Mutation才导致关闭。
|
case1未修改，删除后填充入口仍未消失 |
case1 has not been modified, and the filling entry has not disappeared after deletion. |
oumomomo
added
qa:rejected
and removed
qa:untested
yuhongz
added
bug:should be fixed
qa:untested
oumomomo
added
qa:verified
close #1752