Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conditional-formatting): viewmodel interception is not required a… #2107

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Apr 29, 2024

  1. In version 42, for example, 10 custom formula conditional formats were created.
  2. In version 50, snapshot save.
  3. In version 51, remove 10 custom formula conditional format
  4. Other actions to version 70.
  5. When the user enters version 70, they will pull the CS of 50-70 and version of snapshot 50.
  6. The snapshot of version 50 will have a conditional format, and when applying version 50-70, deleting the 10 custom formulas.
  7. Conditional formatting should not be triggered when applied

Copy link

github-actions bot commented Apr 29, 2024

View Deployment

#8874847702

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 31.05%. Comparing base (fa4ebea) to head (e3cbea0).
Report is 14 commits behind head on dev.

❗ Current head e3cbea0 differs from pull request most recent head 78c2de9. Consider uploading reports for the commit 78c2de9 to get more accurate results

Files Patch % Lines
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 5 Missing ⚠️
...nditional-formatting/src/utils/after-init-apply.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2107      +/-   ##
==========================================
+ Coverage   31.04%   31.05%   +0.01%     
==========================================
  Files        1207     1208       +1     
  Lines       66148    66191      +43     
  Branches    13993    13996       +3     
==========================================
+ Hits        20534    20556      +22     
- Misses      45614    45635      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the gggpound/fix-cf-0429 branch 2 times, most recently from c16436e to 7cff3cb Compare April 29, 2024 07:08
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean.

@Gggpound Gggpound merged commit 305d235 into dev Apr 29, 2024
10 checks passed
@Gggpound Gggpound deleted the gggpound/fix-cf-0429 branch April 29, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants