Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: message service do not return disposable #2155

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 6, 2024

No description provided.

@wzhudev wzhudev requested review from jikkai and Jocs as code owners May 6, 2024 00:34
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (3b45f89) to head (6a9f60f).

Files Patch % Lines
packages/design/src/components/message/Message.tsx 69.23% 4 Missing ⚠️
...ui/src/services/message/desktop-message.service.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2155   +/-   ##
=======================================
  Coverage   31.04%   31.04%           
=======================================
  Files        1209     1209           
  Lines       66240    66241    +1     
  Branches    14014    14014           
=======================================
+ Hits        20563    20564    +1     
  Misses      45677    45677           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wzhudev wzhudev merged commit d831996 into dev May 6, 2024
9 checks passed
@wzhudev wzhudev deleted the feat/message-dispose branch May 6, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants