fix(sheet): find-replace replaceAll only effect on the active sheet #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
oumomomo
added
the
qa:verified
wzhudev
reviewed
May 9, 2024
| let { subUnitId, unitId } = params; | ||
| if (!subUnitId || !unitId) { | ||
| const univerInstanceService = accessor.get(IUniverInstanceService); | ||
| const target = getSheetCommandTarget(univerInstanceService); |
There was a problem hiding this comment.
这里可以通过把 unitId 和 subUnitId 直接传递给 getSheetCommandTarget 方法，方法里已经处理了这些逻辑
There was a problem hiding this comment.
@wzhudev 修改了, 麻烦再看下
siam-ese
force-pushed
the
lzp/fix-replace-all
branch
from
c2f6d55
to
3050202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2163