Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sheet): skip filtered row on setting style #2221

Merged
merged 2 commits into from
May 11, 2024
Merged

fix(sheet): skip filtered row on setting style #2221

merged 2 commits into from
May 11, 2024

Conversation

siam-ese
Copy link
Contributor

close #685

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label May 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

wzhudev
wzhudev approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution looks good to me. The name of the util function should be changed.

packages/sheets/src/commands/commands/utils/selection-utils.ts Outdated Show resolved Hide resolved
@oumomomo oumomomo added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels May 11, 2024
@siam-ese siam-ese merged commit 206e080 into dream-num:dev May 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

@DR-Univer DR-Univer Awaiting requested review from DR-Univer

@jikkai jikkai Awaiting requested review from jikkai jikkai is a code owner

@Jocs Jocs Awaiting requested review from Jocs Jocs is a code owner

Assignees
No one assigned
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siam-ese @wzhudev @oumomomo